Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Providers Documentation #4557

Merged
merged 6 commits into from
Jul 18, 2022

Conversation

Verdent
Copy link
Member

@Verdent Verdent commented Jul 15, 2022

Bound issue: #4308

@Verdent Verdent self-assigned this Jul 15, 2022
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
Signed-off-by: David Kral <david.k.kral@oracle.com>
@m0mus m0mus dismissed tomas-langer’s stale review July 18, 2022 09:19

All review comments are addressed

@Verdent Verdent merged commit 3f4c047 into helidon-io:master Jul 18, 2022
romain-grecourt pushed a commit to MadsBrun/helidon that referenced this pull request Jul 21, 2022
Security Providers Documentation

Signed-off-by: David Kral <david.k.kral@oracle.com>
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Majority of changes were copyright year updates. I verified 2022 in each. Additional comments inline. With the includes its a bit difficult to review, but overall looks good.


// tag::config[]

Http digest authentication security provider
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTTP

present. If set to false, this provider will SecurityResponse.SecurityStatus#FAILURE fail
if signature is not present.
|`outbound` |xref:{rootdir}/config/io_helidon_security_providers_common_OutboundConfig.adoc[OutboundConfig] |{nbsp} |Add outbound targets to this builder.
The targets are used to chose what to do for outbound communication.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The targets are used to choose

@@ -21,6 +21,7 @@ ifndef::rootdir[:rootdir: {docdir}/../../..]
=== ABAC Provider
:description: Helidon Security ABAC Provider
:keywords: helidon, security, authorization, abac
:feature-name: ABAC Security Provider

Attribute based access control authorization provider.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attribute-based access control (ABAC) authorization provider.

|`server-secret` |random |A string to use as a server secret - this is to use digest auth between multiple servers (e.g. when in a cluster). Used to encrypt nonce. This must not be known outside of this app, as others may create digest requests we would trust.
|`qop` |`NONE` |only `AUTH` supported. If left empty, uses the legacy approach (older RFC version). `AUTH-INT` is not supported.
|===

==== How does it work?
See https://tools.ietf.org/html/rfc7616[].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link resolves to this https://datatracker.ietf.org/doc/html/rfc7616 -- a memo from 2015, is this intentional? Also there is no link text in the ref.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants